Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stricter lint package #12

Merged
merged 1 commit into from Oct 25, 2021
Merged

Conversation

lastradev
Copy link
Contributor

Hi! I really liked your project, it's very simple and useful. However, I would like it more with stricter rules.
I changed the linting package to the most used in pub.dev and made several changes so that the compiler and the linting server didn't complain
Including:

  • Changing variables to constants
  • Specifying the types of variables in functions and parameters
  • Adding commas to style the code
  • Changing functions from asynchronous to regular where not needed
  • etc.

You can test it and verify that everything works correctly. However, I recognize that these rules can be subjective and if you prefer to keep the project with the old rules, there would be no problem! I would only appreciate a hacktoberfest-accepted tag.

@google-cla
Copy link

google-cla bot commented Oct 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lastradev
Copy link
Contributor Author

@googlebot I signed it!

@j-j-gajjar j-j-gajjar merged commit face2bc into j-j-gajjar:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants