Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests\Graby\GrabyFunctionalTest::testDate is failing with incorrect date #126

Closed
Kdecherf opened this issue Nov 1, 2017 · 11 comments
Closed

Comments

@Kdecherf
Copy link
Collaborator

Kdecherf commented Nov 1, 2017

On master:

2) Tests\Graby\GrabyFunctionalTest::testDate with data set #1 ('https://www.reddit.com/r/Linu...guide/', '2013-05-30T16:01:58+00:00')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-2013-05-30T16:01:58+00:00
+2013-05-30T16:10:50+00:00

The actual date seems to be the one of the first comment below the main content.

@j0k3r
Copy link
Owner

j0k3r commented Nov 2, 2017

Looks ok on the last build: https://travis-ci.org/j0k3r/graby/builds/296148904
Did you fix it or does it fix by itself? 🤔

@Kdecherf
Copy link
Collaborator Author

Kdecherf commented Nov 2, 2017

The fail was seen on my machine

@aaa2000
Copy link
Contributor

aaa2000 commented Nov 2, 2017

I have the same failed since at least the 16th October. Travis was OK but in local the test failed.

@j0k3r
Copy link
Owner

j0k3r commented Nov 3, 2017

Which version of PHP did you use?

@aaa2000
Copy link
Contributor

aaa2000 commented Nov 4, 2017

I use PHP 7.0.22

@Kdecherf
Copy link
Collaborator Author

Kdecherf commented Nov 4, 2017

7.1.10 here

@j0k3r
Copy link
Owner

j0k3r commented Nov 5, 2017

Ok I'm still working on 5.6 on my dev machine :trollface:

@aaa2000
Copy link
Contributor

aaa2000 commented Nov 5, 2017

The problem is not the php version, I have not the extension php tidy installed

@aaa2000
Copy link
Contributor

aaa2000 commented Nov 5, 2017

Should we skip the test if the extension php tidy is not installed or should we add ext-tidy in require-dev section of composer.json ?

@Kdecherf
Copy link
Collaborator Author

Kdecherf commented Nov 5, 2017

This test is clearly indicating that without ext-tidy some data are incorrectly extracted, we can't just skip it imo.

@j0k3r
Copy link
Owner

j0k3r commented Nov 5, 2017

We shouldn't add tidy as requirement.
But we can try: https://github.com/j0k3r/php-readability/blob/master/tests/ReadabilityTest.php#L26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants