add reset on cache

[fayland]

Sorry i'm using ST3 so it removes extra space in lines.

the fix is mainly

                 if ($cached_result !== false) {
+                    // reset Idiorm after executing the query
+                    $this->_values = array();
+                    $this->_result_columns = array('*');
+                    $this->_using_default_result_columns = true;
+
                     return $cached_result;
                 }

in _run

we'll need reset the _values etc. or else we'll get

Invalid parameter number: number of bound variables does not match number of tokens

b/c I checked, the _values are just duplicated.

I'll provide a test later but from a rough glance, I think it's a bug.

Thanks

[treffynnon]

I don't fully understand the problem that is being solved here. Could you list out the steps to replicate?

[fayland]

it should have same effect why you have those lines in _run few lines later I think.

[treffynnon]

I am still not sure I understand what is happening here. Could you please state the steps required to recreate the issue? On 22 Mar 2017 4:50 p.m., "Fayland Lam" <notifications@github.com> wrote: it should have same effect why you have those lines in _run few lines later I think. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#319 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD-vx4Vz2s1S74e0LGTCptPnlrZRwEhks5roMSngaJpZM4Mkod8> .

[fayland]

dummy code:

ORM::configure('logging', true);
ORM::configure('caching', true);

$rs = ORM::for_table('league')->where('class_id', 1);
$total = $rs->count();
$rows = $rs->limit(1)->find_many();

$rs = ORM::for_table('league')->where('class_id', 1);
$total = $rs->count();
$rows = $rs->limit(1)->find_many();

NOTE first 3 lines set $CACHE.

and second part first line ->count() setup ->_values
then second ->find_many() will be broken with

PHP Fatal error:  Uncaught exception 'PDOException' with message 'SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens' 

if you go dump the _values, you'll find the first ->count does not clear it b/c it returned from the cache.

hope it clears

Thanks

[treffynnon]

Thank you for the pull request. I have written a test and implemented it slightly differently to remove duplication, but it is now merged into develop with commit 5f220f3