New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
count resets after 10ish steps #38
Comments
Grab the debug version here http://j4velin-systems.de/Pedometer.apk and send me a log if the issue occurs again, thx |
I'm getting the same behavior on my Nexus 5, which has happened before. This app badly needs a suite of regression tests. |
There isn't much I can test about it. The sensor reports a step value and the app believes that value is correct |
I have cloned your source code and run the MetricsReloaded plugin to calculate cyclometric complexity on your code, which is 133. What this means that you need 133 unit tests to cover all logical paths in your code base. So there is plenty to test in your project. If you push your gradle.build file to your GitHub repo, I can help you setup some tests. |
You're welcome to do some testing if you want. The most important part however is the SensorListener class and I don't see what could possible go wrong in a method like
|
According to the code you have posted on GitHub, that method does a lot more than that statement. In fact it has a complexity of 15, which is the third highest of all methods in the Pedometer code base (I was wrong in reading the MetricsReloaded plugin before; Pedometer has a total method-level cyclometric complexity of 267). Anyway, as I said, I am willing to help. I did a little more putzing with your source code and discovered it comes from an ADT project. Can you push the version of HoloGraphLibrary that you are using to GitHub? I'm going to setup some Robolectric tests in a separate test project. |
Sorry, I was in the other branch. The Play Store version was from the "test" branch which is now merged into master. The version of the HoloGraphyLibrary I used is on https://bitbucket.org/j4velin/holographlibrary |
Thanks. Can you push your.classpath file to Github? It would make it a lot easier to setup an ADT project locally. |
I'll post it here if that's okay:
|
Count continually resets to 0 after 11 steps. None of the intervening numbers ever appear in app (ie, oscillates between 0 and 11). Restarting phone fixes problem
Nexus 5, most recent app version
The text was updated successfully, but these errors were encountered: