New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and fix build error #68
Conversation
Thank you. I believe I should be able to get to this next weekend, but, if I forget, please ping me after that 😅 |
@RReverser looks like you forgot. 😉 |
Rather, happened to be busier on the weekend than expected :D I'll try to look at this by the end of this week. Sorry for the delay. |
Btw, CI seems to be still failing - can you take a look at why? https://travis-ci.org/github/jDataView/jBinary/builds/766925969 |
I haven't worked with Travis before, but a quick search for the error message gave me this solution: https://stackoverflow.com/questions/55674746/travis-sh-0-cant-open-etc-init-d-xvfb Which seems to have fixed the problem. |
I moved grunt-cli to a dev-dependency; otherwise looks great, thanks a lot for fixing this! |
Made few more cleanups on CI side (including switching to GH actions) and published as 2.1.5. It could probably be interesting to refactor this project to ESM and Rollup too as well as remove various polyfills that are no longer necessary in modern browsers, if it's something you want to look into - unfortunately my area of work has slightly changed over years, but I'm happy to accept contributions :) |
Thanks for the new release. 👍 Maybe you could create Issues with the things you would like to (have) changed. To be honest, I'm currently not interested in binary data related topics. We are using this project to load binary font data that comes from a web service. And as long as it works we are happy with it as it is. |
Makes sense, thanks :) |
This makes the build work again. Closes #67
There are still two packages complaining about incorrect peer dependencies:
npm WARN grunt-concat-sourcemap@0.4.3 requires a peer of grunt@~0.4.1 but none is installed. You must install peer dependencies yourself. npm WARN grunt-karma@4.0.0 requires a peer of karma@^4.0.0 || ^5.0.0 but none is installed. You must install peer dependencies yourself.
Unfortunately there is no update for these packages.
I tested the Node.js output locally and it does fix #46 for me. Haven't tested the browser version though. Tests seem to be working. Could you recheck please?