fix: XSS vulnerability #137
Merged
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @catnose99, thanks a lot for reporting & fixing this bug! Your PR is currently failing in CI because For your PR to be merged, it needs at least one unit test. Will you write one or shall I take over? |
|
I removed commitlint in #138. If you rebase your branch, the CI should pass. |
|
@catnose99, since you have not replied regarding whether you’ll write the unit test, I went ahead and did it myself. Once again: thank you for your contribution! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2020
## [2.1.2](v2.1.1...v2.1.2) (2020-09-29) ### Bug Fixes * escape the language class name so it cannot be used to inject HTML ([#137](#137)) ([c1c074b](c1c074b))
|
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a XSS vulnerability around filenames.
Here is a example to reproduce.
I made a change so that filenames are escaped.
Thank you!