Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong callback to JmeSurfaceView#destroy() #1799

Closed
Scrappers-glitch opened this issue Apr 18, 2022 · 2 comments · Fixed by #1801
Closed

Wrong callback to JmeSurfaceView#destroy() #1799

Scrappers-glitch opened this issue Apr 18, 2022 · 2 comments · Fixed by #1801
Labels

Comments

@Scrappers-glitch
Copy link
Contributor

Scrappers-glitch commented Apr 18, 2022

As i recall, app.destroy() is called back by the system listener which is governed by application listeners, in this case there is a duplicate call to destroy() :

There should only be app.stop() which will naturally dispatch the context.destroy().

The proposed fix should move the legacyApplication.stop(!isGLThreadPaused()); to the ON_DESTROY instead of the direct call to destroy() and should call legacyApplication.destroy() inside the destroy().

@stephengold
Copy link
Member

@Scrappers-glitch Will you provide us with a PR?

@Scrappers-glitch
Copy link
Contributor Author

Yeah sure, i will do a PR at the end of this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants