Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LWJGL to 3.1.6 #871

Closed
tonihele opened this issue Jul 16, 2018 · 5 comments
Closed

Update LWJGL to 3.1.6 #871

tonihele opened this issue Jul 16, 2018 · 5 comments
Milestone

Comments

@tonihele
Copy link
Contributor

tonihele commented Jul 16, 2018

Update LWJGL to 3.1.6.

Also there is a bug in the context creation. The if the context is re-created at any point, it will crash. This is due to adding the error listener to GLWF that has already been freed but the pointer still exists in GLWF. This is reproducible always when running the examples with the example chooser and choosing i.e. BrickWall. First time ok, second time crash.

@tonihele
Copy link
Contributor Author

I'll create a PR in just a minute, I can't add myself as a assignee. GIT n00b still. Lets see :)

@tonihele tonihele mentioned this issue Jul 16, 2018
@tonihele
Copy link
Contributor Author

tonihele commented Jul 16, 2018

Hmm, I did it twice with both branches having the same issue, I don't know what is causing all the white space changes :( I didn't have any auto-formattings on, at least I shouldn't have had.

And I took the liberty to change the LinkedLists back to ArrayDeques. Since last time this was an allowed move, and seems that they might have been changed back due to some refactoring etc. Anyway, it should be better, marginally.

@tonihele tonihele mentioned this issue Jul 17, 2018
@tonihele
Copy link
Contributor Author

Ok, now it should be ok. I redid it, and I don't know why this time it worked. But it did, so, great :)

@stephengold
Copy link
Member

I'm unsure whether to include this in v3.2.2 . How risky is the fix?

@tonihele
Copy link
Contributor Author

Hmm, not super risky I'd say. It was 3.1.5 -> 3.1.6, https://github.com/LWJGL/lwjgl3/releases. I did try the demos and they worked. And actually there was a fix included in this to how JME uses LWJGL 3 context, as I mentioned. So I'd say... yay, go for it :)

@stephengold stephengold added this to the v3.2.2 milestone Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants