Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

XMLFileFilter should ignore initial comments #4

Closed
DirkMahler opened this issue Aug 16, 2017 · 3 comments
Closed

XMLFileFilter should ignore initial comments #4

DirkMahler opened this issue Aug 16, 2017 · 3 comments
Assignees
Labels
status:done All work related to this issue has been done type:bug Software shows incorrect behavior or delivers incorrect results
Milestone

Comments

@DirkMahler
Copy link
Contributor

XMLFileFilter is used identify the JPA version of persistence.xml files but currently fails if the first element in the file is a comment, e.g.

<?xml version="1.0" encoding="UTF-8"?>
<!--
Some comment
  -->
<persistence version="2.1" ..
@yrodiere
Copy link

@DirkMahler Hi!

We recently hit on this bug when we tried to use jqassistant on https://github.com/hibernate/hibernate-search. There doesn't seem to be a workaround except changing the XML files, which is not really an option in our case.

Do you think you will be able to release version 1.4 anytime soon? That would be greatly appreciated.

@DirkMahler
Copy link
Contributor Author

It's planned for beginning/mid of May, so hopefully not too much time to wait for you to... Do you have the chance to verify if the current 1.4.0-SNAPSHOT version works for you? It's available from the Sonatype OSS Snapshot repository (https://oss.sonatype.org/content/repositories/snapshots/).

@yrodiere
Copy link

yrodiere commented Apr 24, 2018

Do you have the chance to verify if the current 1.4.0-SNAPSHOT version works for you?

I just did, and it works like a charm :)

It's planned for beginning/mid of May, so hopefully not too much time to wait for you to...

We'll wait, thanks!

yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 4, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 4, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 4, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jun 4, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jul 30, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jul 30, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jul 30, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jul 31, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Jul 31, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Aug 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Aug 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Aug 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Aug 1, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Aug 2, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Aug 2, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Aug 30, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Aug 30, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 3, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 4, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 4, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 4, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 5, 2018
yrodiere added a commit to yrodiere/hibernate-search that referenced this issue Sep 5, 2018
@obfischer obfischer added status:done All work related to this issue has been done type:bug Software shows incorrect behavior or delivers incorrect results and removed bug labels Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:done All work related to this issue has been done type:bug Software shows incorrect behavior or delivers incorrect results
Projects
None yet
Development

No branches or pull requests

3 participants