Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you increase armor protection beyond 128%, then in the merc inventory, overall protection has a negative status, like "-125%" #1938

Open
Inveriss opened this issue Dec 3, 2023 · 1 comment
Labels
bug vanilla Bugs that exist in the original JA2 game

Comments

@Inveriss
Copy link

Inveriss commented Dec 3, 2023

What is wrong

In source code in file "Weapons.cc" at the beginning of the file we have "ARMOURTYPE const Armour[] =" where we can find all protection settings for every armor in the game. When we increase our armor beyond 128% then directly in the game, the overall protection will have minus sign like "-125%"

JA2S version Game version Vanilla bug? Used to work?
0.21.0 Stable JA2 Gold 1.12 ENG yes no

//: # 1. Let's take merc Gus for example because he has all kevlar protection at the beginning of the game.
//: # 2. Open weapons.cc and change all standard kevlar armor protection to let's say 100. It will be enough, that in the game protection will be beyond 128%.
//: # 3. Compile the new exe file, start the game, and Gus should have "-19%" in his overall protection description.

//: # Windows 10

@lynxlynxlynx
Copy link
Member

It should be capped at 100 %, regardless what silly values users put in.

@lynxlynxlynx lynxlynxlynx added bug vanilla Bugs that exist in the original JA2 game labels Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug vanilla Bugs that exist in the original JA2 game
Projects
None yet
Development

No branches or pull requests

2 participants