-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
color:change fires before input:start #59
Comments
Hey! Thanks for flagging this issue I agree that your suggested event order makes more sense, I've just pushed a hotfix (ver 4.2.2) which should fix that. 👍 It's worth noting that color:update also (intentionally) fires once with the initial color value too |
As of v4.3.0 there's now a built-in |
Hmm. Are you sure this works in the latest version (@jaames/iro@5.2.3). I'm seeing I'm seeing the wrong order in Slider too, but it fires just once. |
@ile this is a different issue, but yes it looks like you're right. I'll take a look after the weekend |
I'm using input:start and :end to disambiguate when the user makes a change vs when the color changes by code. When I see input:start, I set a boolean to indicate the user is interacting. When I see input:end, I turn it off. However due to the order of the events, this doesn't work. If I click on the color picker (at least on firefox), the events are:
Steps 1 and 2 should be swapped.
I am able to work around this issue by manually calling my onColorChange handler inside my input:start handler, but this seems like something that should be fixed.
The text was updated successfully, but these errors were encountered: