Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Bujo backarrow #1332

Conversation

RonnyPfannschmidt
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt commented Nov 25, 2020

this adds a bullet journal back arrow to complements the already existing arrow for documenting the normal migration

the bullet journal method has 2 types of migration

  • > migration which documents the move of a task not completed in the current day/log to a new day/log
  • < migration, which documents the move of a task to a future collection for further refinement

as it affects both text syntax and integrated actions i saw no way of implementing this in a plugin

its possible to go on with just documenting everything as "normal migration" but that takes away information useful for reflection

TODO:

  • check wiki format version bump
  • mini intro for bujo
  • squash

@RonnyPfannschmidt
Copy link
Contributor Author

the feature now roughly works

@RonnyPfannschmidt RonnyPfannschmidt changed the title [WIP] Bujo backarrow [WIP] Feature: Bujo backarrow Nov 25, 2020
@pfalcon
Copy link
Contributor

pfalcon commented Nov 25, 2020

What is bujo backarrow? Why do we need bujo backarrow? How did we manage to survive without bujo backarrow for so long?

See https://github.com/zim-desktop-wiki/zim-desktop-wiki/blob/master/CONTRIBUTING.md#adding-new-features for inspiration.

@RonnyPfannschmidt
Copy link
Contributor Author

the bullet journal back arrow complements the already existing arrow for documenting the normal migration

the bullet journa method has 2 types of migration

  • > migration which documents the move of a task not completed in the current day/log to a new day/log
  • < migration, which documents the move of a task to a future collection for further refinement

as it affects both text syntax and integrated actions i saw no way of implementing this in a plugin

its possible to go on with just documenting everything as "normal migration" but that takes away information useful for reflection

@pfalcon
Copy link
Contributor

pfalcon commented Nov 25, 2020

Counter-argument to that is that even existing Zim "extensions" pose interoperability issues with other (more popular, up to being a de-facto standard) markup formats (e.g. #26 (comment)).

@RonnyPfannschmidt
Copy link
Contributor Author

if interoperable means that everyone can do next to nothing, that seems to be a flaw
there always is a friction between common feature sets and distinctive features.

As the de-facto standards are not extensible, this is a problem.

even for restructured text only a crude hack comes to mind to add this feature in a pristine way.

@pfalcon
Copy link
Contributor

pfalcon commented Nov 25, 2020

I fully agree that "if Zim already went beyond simple on/off checkboxes, then it as well can be extended further" is a good argument, I just point out it's not the only argument ("stop any adhoc additions" is also a pretty good one).

The biggest point though is that proposed changes should be well described (and even justified). As of now, the description here is still:

this intends to add bujo style back arrows to checkboxes

Hopefully, that will be fixed eventually.

@jaap-karssenberg
Copy link
Member

Patch looks good to me and I intend to merge it. Could you also add some content to the manual (data/manual in the source folder) explaining this checkbox type? Maybe even a short intro to bullet journaling in the "usage" section. Also would like to see a test case that uses this checkbox type to make sure it does not break later.

With respect to the above discussion. Since I already added "[>]" I see no good argument to block "[<]". Yes, this poses an issue when we go to MarkDown, but merging now in our wiki format still leaves open the choice what we support for MarkDown and how we do that. So not a blocking issue right now.

Regards,

Jaap

@RonnyPfannschmidt
Copy link
Contributor Author

should there be a bump of the wiki format version number (so old zim does not stumble?

@jaap-karssenberg
Copy link
Member

jaap-karssenberg commented Dec 4, 2020 via email

@RonnyPfannschmidt
Copy link
Contributor Author

@jaap-karssenberg do you by chance know a example of the escaping mechanism - i'd like to attempt the version bump if i can figure a sensible iteration sometime this month, else i'll defer to the non-bump version (which is also fine, just irks me if i haven't at least tried the bump)

@jaap-karssenberg
Copy link
Member

jaap-karssenberg commented Jan 13, 2021 via email

@RonnyPfannschmidt
Copy link
Contributor Author

I see, in that case a escape is not a sustainable way to do it right now,

If you agree that the risk is acceptable, I'd like to implement it without version bump then

@jaap-karssenberg
Copy link
Member

jaap-karssenberg commented Jan 14, 2021 via email

@RonnyPfannschmidt RonnyPfannschmidt changed the title [WIP] Feature: Bujo backarrow Feature: Bujo backarrow Jan 15, 2021
this adds
* transmigrated box stock image via `convert -flop migrated-box.png transmigrated-box.png`

* `[<]` as bullet type to signify migration to the future log
* simplify bullet icon lookup and use the reverse mapping for membership testing
* add a initial basic howto on what to do to map BUllet Journal to Zim
@RonnyPfannschmidt
Copy link
Contributor Author

@jaap-karssenberg gentle ping on this one,
i forgot to mention that i ended the experiment,
i'd appreciate if this was part of one of the next releases

@jaap-karssenberg
Copy link
Member

jaap-karssenberg commented Apr 7, 2021 via email

@introt

This comment has been minimized.

@RonnyPfannschmidt
Copy link
Contributor Author

@introt thanks for iterating on the details, i wasn't aware how many detail locations i missed, i wonder of this can be condensed/dry-ed out as a follow-up

@introt
Copy link
Collaborator

introt commented May 29, 2021

No problem! Took me a while to find them all, in the end I just grepped for the MIGRATED_BOX and worked the missing pieces out from there...

I've cherry-picked the changes into your branch and closed #1473. You should be able to include those commits in this PR by merging RonnyPfannschmidt#1 (comment)

- data/menubar.xml: show transmigrate_checkbox @action
- data/style.conf: add transmigrated-checkbox [Tag]
- tests/pageview.py: add test for transmigrate_checkbox()
- zim/formats/*.py: add TRANSMIGRATED_BOX to BULLETS
- zim/gui/pageview/__init__.py: add missing code and documentation; fix
ordering of popup menuitems (now same as tick order)
@jaap-karssenberg
Copy link
Member

@RonnyPfannschmidt do you want to check and merge the fixes by @introt - or shall I have a go at merging both pulls ?

@RonnyPfannschmidt
Copy link
Contributor Author

Thanks for the ping, I missed the pr on my fork, will give it a try in about 10

@RonnyPfannschmidt
Copy link
Contributor Author

@jaap-karssenberg th merge went well, i'll now take a look at running the tests again

@jaap-karssenberg
Copy link
Member

Thanks ! Now fully merged this tree into develop. In case of further updates, please commit a fresh pull request on a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants