Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logging/error-reporting system #18

Closed
adamhutchings opened this issue Oct 1, 2023 · 2 comments · Fixed by #42
Closed

Adding logging/error-reporting system #18

adamhutchings opened this issue Oct 1, 2023 · 2 comments · Fixed by #42
Assignees
Labels

Comments

@adamhutchings
Copy link
Contributor

No description provided.

@adamhutchings
Copy link
Contributor Author

Discuss here -- should the logging/error-reporting system be exposed through the API?

@JakeRoggenbuck
Copy link
Member

Discuss here -- should the logging/error-reporting system be exposed through the API?

What would this mean in practice?

I think the library user should be able to set the log level. This should be exposed by the API.

jml::global_log_level(DEBUG);

Should the library users be able to call the logger itself? Probably not. We probably don't need to allow the following.

jml::log(DEBUG, "This is a debug message");

Would the user need or want to access the data of the logs for any reason? Like programmatically check if any warnings have been created?

@JakeRoggenbuck JakeRoggenbuck mentioned this issue Oct 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants