Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit format of SA template uploads to .docx #2402

Merged

Conversation

KoWeiJAC
Copy link
Contributor

@KoWeiJAC KoWeiJAC commented May 15, 2024

What's included?

closes #2391

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Include screen grabs, video demo, notes etc.

Related permissions

Have permissions been considered for this functionality?

  • No permission changes required
  • Permissions have been added / updated. Details:

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented May 15, 2024

Visit the preview URL for this PR (updated for commit a0e7b45):

https://jac-admin-develop--pr2402-feat-admin-2391-limi-kdfniodr.web.app

(expires Thu, 27 Jun 2024 11:06:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@KoWeiJAC KoWeiJAC self-assigned this May 16, 2024
@KoWeiJAC KoWeiJAC marked this pull request as ready for review May 16, 2024 08:11
@KoWeiJAC KoWeiJAC requested review from a team as code owners May 16, 2024 08:11
@nickaddy
Copy link
Contributor

@KoWeiJAC Pls chase Drie for a review so you can merge and close once passed.

@HalcyonJAC HalcyonJAC changed the title can only upload .docx SA template Limit format of SA template uploads to .docx May 28, 2024
@HalcyonJAC HalcyonJAC merged commit 01f68c0 into main May 28, 2024
10 checks passed
@HalcyonJAC HalcyonJAC deleted the feat/admin-2391-limit-format-of-SA-template-uploads-to-docx branch May 28, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit format of SA template uploads to .docx
7 participants