Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional working preferences questions appear as mandatory on Apply #1178

Open
warrensearle opened this issue Jun 3, 2024 · 3 comments
Open
Assignees
Labels
Bug Something isn't working

Comments

@warrensearle
Copy link
Member

warrensearle commented Jun 3, 2024

Describe the bug

It is now possible in Admin to configure working preferences questions as optional, however, on Apply, questions configured this way still appear to be mandatory.

Expected behaviour

Questions marked as optional in Admin should not be mandatory on Apply.

Screenshots

Admin. Configuring working preferences
Note the first question is optional

image

Apply. Answering working preferences

Note the 'Save and continue' button is disabled. It should not be as the form has sufficient data entered (the first question is optional)

image

Additional context

The save button only becomes enabled when all questions have been answered. We need to ensure optional questions are excluded from this check.

@nickaddy
Copy link
Contributor

nickaddy commented Jun 4, 2024

@nickaddy nickaddy changed the title Working preferences. Optional question is still mandatory Optional working preferences questions appear as mandatory on Apply Jun 4, 2024
@nickaddy nickaddy added the Bug Something isn't working label Jun 4, 2024
@drieJAC
Copy link
Contributor

drieJAC commented Jun 6, 2024

Do we need to preserve existing behaviour for version 1 Working Preferences questions?

@nickaddy
Copy link
Contributor

nickaddy commented Jun 7, 2024

@drieJAC I believe WP questions were mandatory for v1. As we haven't fully released v2, I'm not sure when or if there is a cut-off date for exercises using v1. It's possible there could be exercises in draft status that will be using v1, so I suppose, yes, we need to preserve existing behaviour for any exercises using v1.

@tomlovesgithub tomlovesgithub self-assigned this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants