Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete version not working properly #14

Open
michael-mhrdd opened this issue Mar 27, 2021 · 1 comment
Open

complete version not working properly #14

michael-mhrdd opened this issue Mar 27, 2021 · 1 comment

Comments

@michael-mhrdd
Copy link

When running the complete version locally, it differs from app.learnreframe.com: After agreeing to become a chef and adding a recipe, then opening it,

  • the green button at the at the top right says "Order for NaN €" instead of "Publish".
  • the Steps + and Ingredients + buttons have no effect (I can't add ingredients and steps).
  • When navigating back to recipes, then new recipe has disappeared.

npm install produces these warnings:
npm WARN deprecated highlight.js@9.18.5: Support has ended for 9.x series. Upgrade to @latest
npm WARN deprecated polished@2.3.3: polished@2.X is no longer supported. Please upgrade to @latest f
or important bug and security fixes.

at the end of npm run dev, i get:
Warning: Nashorn engine is planned to be removed from a future JDK release

Also, the re-frame-10x tab is strangely formatted:

image

@anderskitson
Copy link

As for the re-frame-10x tab what I did to fix that whole UI was

was changing re-frame version in shadow-cljs.edn

to

[day8.re-frame/re-frame-10x "1.2.1"]

and the reagent version to

[reagent "1.1.0"]

this also required me to update the the core.cljs file to the following

(ns app.core
  (:require [reagent.core :as r]
            ;; addition here
            [reagent.dom  :as rd]))

(defn app
  []
  [:div "Cheffy"])

(defn ^:dev/after-load start
  []
  ;; change to rd
  (rd/render [app]
    (.getElementById js/document "app")))

(defn ^:export init
  []
  (start))

remember to stop and start server, either npm run dev or yarn dev

I am also running node 12 so that may help with the node warnings.

As for the functionality of the rest of the features I am not sure, but will message when I get to that part, I have started over because my REPL was way to broken and couldn't fix it.

Anyways hope this is of some help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants