Support for cards' direction and respective moves color #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight". This causes the cards to display the moves in the respective colors (yellow-ish, blue or red), as the real game cards do.
jackadamson
approved these changes
Apr 17, 2023
|
Really like this change, though I intend to tweak the colors slightly New colors were generated using the Material Color palettes tool based on the Before
After
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for cards' direction, which can be "balanced", "left" or "right". This causes the cards to display the moves in the respective colors (yellow-ish, blue or red), as the real game cards do.
Note: implicitly contains the Sensei's Path PR ( #13 ), because I had to also add colors for those cards.
PS. Also, some fixes around for Windows machines :) (like crossenv and gitattributes)