Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch master should send sample-rate and buffer-size change callbacks #32

Closed
falkTX opened this issue May 9, 2013 · 3 comments
Closed

Comments

@falkTX
Copy link
Member

falkTX commented May 9, 2013

As the title says, when doing switch-master, JACK should send sample-rate and buffer-size change callbacks as needed.
Currently it's possible to change JACK sample-rate and buffer-size on the fly via switch master, but the clients never get notified of it.

@sletz
Copy link
Member

sletz commented May 9, 2013

Can you try the following patch and report:

diff --git a/common/JackServer.cpp b/common/JackServer.cpp
index 729608d..2480397 100644
--- a/common/JackServer.cpp
+++ b/common/JackServer.cpp
@@ -401,6 +401,9 @@ int JackServer::SwitchMaster(jack_driver_desc_t* driver_desc, JSList* driver_par
}

fAudioDriver->SetMaster(true);
  • // Notify clients of new values
  • fEngine->NotifyBufferSize(fEngineControl->fBufferSize);
  • fEngine->NotifySampleRate(fEngineControl->fSampleRate);
    return fAudioDriver->Start();

Stéphane

@sletz
Copy link
Member

sletz commented May 14, 2013

Should be fixed in eacbd3e

@sletz sletz closed this as completed May 14, 2013
@falkTX
Copy link
Member Author

falkTX commented May 22, 2013

Sorry for the late answer.
I can confirm that the bug is indeed fixed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants