New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should setting open attribute cancel timeouts? #52

Open

fergald opened this issue Jul 23, 2019 · 0 comments

Collaborator

fergald commented Jul 23, 2019

What should

toast.show();
toast.setAttribtue("open", "");

do? Should it still close after a timeout?

toast.show();
toast.removeAttribtue("open");
toast.setAttribtue("open", "");

will cancel the close-after-timeout callback.

Whatever the answer is, we should make it clear in the explainer how manipulating the attribute impacts the timeout behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment