Configure racket/racket as primary repository #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the primary image repository to racket/racket, with jackfirth/racket preserved as a secondary repository for backwards compatibility. All images are pushed to both repositories, but the intent is that users of the jackfirth/racket repository should switch to the racket/racket repository. Both tags of the same images are tested in order to ensure they were tagged correctly and really do refer to the same image. Also, this commit removes the DOCKER_USERNAME environment variable and replaces it with constants in _common.sh, since there's no particular reason that info needed to be passed through the CircleCI config. Note that the DOCKER_USERNAME variable, used to name the images, was distinct from the DOCKER_USER_NAME variable, which was used to login to DockerHub. The latter remains and is configured within CircleCI directly alongside an email and password.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43. This commit changes the primary image repository to
racket/racket, withjackfirth/racketpreserved as a secondary repository for backwards compatibility. All images are pushed to both repositories, but the intent is that users of thejackfirth/racketrepository switch to theracket/racketrepository. Both tags of the same images are tested in order to ensure they were tagged correctly and really do refer to the same image.Also, this commit removes the
DOCKER_USERNAMEenvironment variable and replaces it with constants in_common.sh, since there's no particular reason that info needed to be passed through the CircleCI config. Note that theDOCKER_USERNAMEvariable, used to name the images, was distinct from theDOCKER_USER_NAMEvariable, which was used to login to Docker Hub. The latter remains and is configured within CircleCI directly alongside an email and password.