Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTD on entering vehicle #20

Open
GrimGadget opened this issue Oct 31, 2022 · 4 comments
Open

CTD on entering vehicle #20

GrimGadget opened this issue Oct 31, 2022 · 4 comments

Comments

@GrimGadget
Copy link

I sometimes get a CTD when entering a vehicle.

I have IWN set for driving only.
I have changed the settings to double the distance between markers and generate half the markers. (10/100)

It seems so far that it only happens if I have a destination set already when I go to enter the vehicle.

I believe it most likely to be a timing issue caused by the mod attempting to load the route at the same time the minimap is attempting to switch from on-foot to driving mode.

CTD Helper log attached
ctd_helper.log

@jackhumbert
Copy link
Owner

Thanks for the log - it looks like it's crashing near this redscript line: https://github.com/jackhumbert/in_world_navigation/blob/main/src/redscript/in_world_navigation/InWorldNavigation.reds#L238

@GrimGadget
Copy link
Author

An additional note.

I just discovered that it sometimes CTDs also when sitting in a car and setting/changing missions. Again, it appears most likely to be an issue with the mod attempting to load the path at the same time it's being set/altered by the main game code.

This log shows 3 different threads with overlapping executions of UpdateNavPath at the same time. I was in the car, active mission was to wait on someone to call back. So I changed to track a different side job with a location, and as soon as I clicked on Track Job, the game CTD'd.

Maybe two threads attempting to modify and/or read the navPathFXs array at the same time?

ctd_helper.log

@GrimGadget
Copy link
Author

I just discovered that it sometimes CTDs also when sitting in a car and setting/changing missions. Again, it appears most likely to be an issue with the mod attempting to load the path at the same time it's being set/altered by the main game code.

Ignore this one. Not caused by this mod. It just happened to me again when I switched jobs and wasn't even near a car. This one is caused by something else.

I'm still curious why three threads are in the UpdateNavPath method at the same time, though.

@phntsm
Copy link

phntsm commented Mar 4, 2023

You ever figure out what was causing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants