New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorbox modal mode needed #134
Comments
In case options contain modal = true, $.colorbox.close() would be required to close the window. |
I'm always hesitant to add new options, especially when a feature can be replicated fairly easily through JS or CSS. But, I agree it needs to be more convenient to hide the close button. How about instead of a modal option, there is a new option for hiding the close button. This will give the most flexibility, and it's easy enough to change the defaults that having to set 2 additional properties shouldn't be that much of a burden. Does this sound acceptable? |
Sorry missed your comment, @jackmoore. Sure, even the option for removing/hiding close button is good. |
I'll put it in. I looked into other lightboxes to see what their 'modal' option did, and it doesn't seem to match the original poster's definition, except for maybe Fancybox. Shadowbox's and jQuery UI dialog's modal option seems to be the equivalent to Colorbox's overlayClose option. I think just adding the ability to remove the close button will be clearer than combining options. |
Hello- first off, colorbox is a really cool pluggin! Thank you. |
@PaulGobin , but when ColorBox is opened it puts greyed out div behind it and you can't really click anywhere on the page. If you press Esc or click on that div, then ColorBox window closes. That is real modal window. |
I actually set the opacity to 0 and overlay close to false. This allows the user to still see the contents of the parent page and can only close the pop-up video chat by clicking the close (X) button (I understand it still has the overlay but it's transparent) |
Colorbox might not be the right plugin for what you are trying to do. It would be easy to hide or remove the overlay. You could delete the element from the DOM, or hide it with css, like so:
But Colorbox lacks the ability to let the user control it's positioning, unlike something like jQuery dialog from the jQuery UI kit. |
@jackmore |
@jackmoore To be able to move the colorbox around the screen, I add the following JS: //functionality to drag the dialog |
When this option enabled, overlayClose and escKey must be set to "false", and close button must be hidden.
Now I do it manually, it's sad. Shadowbox has this option.
The text was updated successfully, but these errors were encountered: