New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorbox + jQuery 1.8.0 #239
Comments
I've also noticed this, the fade transition just breaks horribly here, only showing a ~ 20x20px box. |
I've tested with 1.8 and haven't had any issues yet. Can you provide any more details on how to reproduce the problem you are having? |
I didn't test old versions of colorbox, so if it isn't the most recent one let me know. |
I'm using 1.3.19 with jQuery 1.8.0. This is an "out-of-the-box" copy of Colorbox. I also have the issues on another site, same versions, with a slightly modified Colorbox script (I added the ability to apply a custom class to the colorbox). Here are the defaults I have set:
And here's my call to the ColorBox:
|
I've tested with latest one, shouldn't be anything weird in my setup. |
Here is a demo using 1.8 with both fade and elastic transitions: Do either of you experience a problem with it? |
The fiddle works correctly. I copied all the code over to my server, still worked correctly. Changed the links to the files on my server, still worked correctly. Obviously, something I'm doing on my end is causing the issue, whether it be style or script. I'm looking into it further. I apologize for the false report. |
Do you happen to be using jQuery UI? I had one report of a UI user with an issue that I haven't looked into yet. |
Yes, it is jQuery UI. I was just preparing the fiddle: http://jsfiddle.net/hY4ZZ/ |
I can confirm that jQuery UI is the trouble maker here too. |
It seems like jQuery UI is modifying jQuery's animate method. In instances where the animation speed is 0, animate is supposed to set the CSS properties to their final step. When jQuery UI is added, it seems to skip that step. Found an open ticket for this exact issue: http://bugs.jquery.com/ticket/12273 Updating to jQuery-ui 1.9 beta solved the issue. But, I went ahead and added a workaround to ColorBox. Only the jquery.colorbox.js file changed, so you can grab that from here or the minified (UglifyJS) from the zip on my site. Thanks for bringing it to my attention. |
First of all Colorbox is great. I hae an issue about numbers. Problem is; i have 4 pictures but it shows 5 . I want to correct {current} and {total} parameter but i cant. I can i fix this issue. It dublicate the first image. ( i mean 1 of 5 and 2 of 5 is the same picture and also i have 4 pictures at total not 5) |
When using jQuery 1.8.0, the "elastic" transition method fires from the top left corner of the screen the first time Colorbox is called. Every time after, it doesn't transition; it just pops up on the screen.
It also looks like the loading animation portion is completely broken, as it doesn't show up. Doing some fooling around in the web developer tools in Chrome, I can see the divs are there, however, they have a height of 0px.
The text was updated successfully, but these errors were encountered: