Update TextIcon.java

[ghost]

This change modifies
TextIcon.java to create a multi-line image if the input test contains multiple lines, and
ColorValue.java to change the applicable EditText to multi-line.

This change requires a simple test before acceptance. After build,
create a shortcut with a single line of text and verify that it appears normal, and
create a shortcut with two or three short lines of text and verify that it appears as expected.

I apologize for not testing but I cannot run Android Studio. I have tested the code in another application, but not in TEA.

[jackpal]

Thanks Frank. I'll take a look at this in a few days -- I'm busy at work
for the next week or so. I'm sorry that you can't use Android Studio -- is
it because you develop on-Android? Can you run the command-line (gradle)
builds on-Android?

On Thu, Mar 5, 2015 at 6:57 AM Frank P. Westlake notifications@github.com
wrote:

This change modifies
TextIcon.java to create a multi-line image if the input test contains
multiple lines, and
ColorValue.java to change the applicable EditText to multi-line.

This change requires a simple test before acceptance. After build,
create a shortcut with a single line of text and verify that it appears
normal, and
create a shortcut with two or three short lines of text and verify that it
appears as expected.

I apologize for not testing but I cannot run Android Studio. I have tested

the code in another application, but not in TEA.

You can view, comment on, or merge this pull request online at:

#391
Commit Summary

• Update TextIcon.java

File Changes

• M term/src/main/java/jackpal/androidterm/shortcuts/TextIcon.java
  https://github.com/jackpal/Android-Terminal-Emulator/pull/391/files#diff-0
  (68)

Patch Links:

• https://github.com/jackpal/Android-Terminal-Emulator/pull/391.patch
• https://github.com/jackpal/Android-Terminal-Emulator/pull/391.diff

—
Reply to this email directly or view it on GitHub
#391.

[ghost]

From JackPalevich:

Thanks Frank. I'll take a look at this in a few days...

Thanks, it's obviously a very low priority -- an
anti-priority I suppose.

I'm sorry that you can't use Android Studio -- is
it because you develop on-Android? Can you run the command-line (gradle)
builds on-Android?

Thanks for the hint, I thought Android Studio was
Windows-only -- I'll look harder for Linux and Android
options (remember that I am not a real programmer).

Frank

[jackpal]

Yeah, I can see why the use of the word "Studio" might lead you to believe that Android Studio was somehow part of Visual Studio. Confusing naming. But in fact Android Studio is based on "JetBrains" IDE, which is Java based, similar to Eclipse. Android Studio is available on Windows, Mac, and Linux. Visit http://developer.android.com/sdk/index.html to download it.

[jackpal]

I tested single-line and mult-line text, and both seemed to work.

[ghost]

From JackPalevich:

Visit http://developer.android.com/sdk/index.html to
download
it.

I started to install it a few days ago but it requires
acceptance of the normal Google anti-privacy agreement,
which I will not agree with. So I'm slowly learning how
to make gradle build from the command line. It'll be
slow because I've never used Grade, Maven, or any other
such system -- I just compiled C with a command line
Borland compiler.

Thanks for the pull!

Frank