handling of shift+backspace key to emit a forward_delete on TF101

[dvhh]

On TF101 intercepted the specified key combination in the keyDown handler to replace the event and keycode with one that simulate pressing the the delete key.

As requested the feature request #240

[jackpal]

I don't want to accept this patch. It is device specific. I don't want to
go down the route of adding device specific features. Either figure out a
generic keyboard mapping system (which is a lot of work, but potentially a
big benefit) or do this in your own private fork of the app.

On Tue, Apr 7, 2015 at 2:15 AM dvhh notifications@github.com wrote:

On TF101 intercepted the specified key combination in the keyDown handler
to replace the event and keycode with one that simulate pressing the the
delete key.

As requested the feature request #240

https://github.com/jackpal/Android-Terminal-Emulator/issues/240

You can view, comment on, or merge this pull request online at:

#422
Commit Summary

• Implemented handling of shift+backspace key to emit a
  forward_delete key on TF101

File Changes

• M
  emulatorview/src/main/java/jackpal/androidterm/emulatorview/EmulatorView.java
  https://github.com/jackpal/Android-Terminal-Emulator/pull/422/files#diff-0
  (9)

Patch Links:

• https://github.com/jackpal/Android-Terminal-Emulator/pull/422.patch
• https://github.com/jackpal/Android-Terminal-Emulator/pull/422.diff

—
Reply to this email directly or view it on GitHub
#422.

[frol]

Why do you need the check Build.MODEL.contains("Transformer TF101") at all?

P.S. my device is TF300T and, I think, this feature will work nice for all devices, not only TF100, TF101, TF200, TF300, TF700, TF701...

[dvhh]

@jackpal
No problem, I also wanted to work on a more generic remapping framework, as it might also solve the issue for other devices with physical keyboard, buttons that need remapping (like #292 #293 ).

@frol
I was checking for the device as it was requested in your issue (owning the device I could perform the tests ), but I didn't want to introduce the behavior for other keyboard/device. In the meantime I could provide some special build for your device (transformer series). I'll fix the test and provide a link in your issue.

[frol]

@dvhh Thank you!