Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests on master #94

Closed
SolidTux opened this issue Jul 17, 2023 · 3 comments
Closed

Failing tests on master #94

SolidTux opened this issue Jul 17, 2023 · 3 comments

Comments

@SolidTux
Copy link
Contributor

SolidTux commented Jul 17, 2023

@SolidTux Thanks again for submitting. I've proposed a few changes to the intended behaviour, but implementation otherwise looks good.
 
[test_that_main_produces_expected_output](https://github.com/jacksmith15/statham-schema/blob/master/tests/component/test_generation.py#L19) fails on a few cases where the schema under test contains descriptions. This test just runs code generation on each of the schemas in [tests/jsonschemas/](https://github.com/jacksmith15/statham-schema/tree/master/tests/jsonschemas) and compares the resulting ASTs to the corresponding files in [tests/models/](https://github.com/jacksmith15/statham-schema/tree/master/tests/models).
 
Resolving these should be as simple as updating the files in [tests/models/](https://github.com/jacksmith15/statham-schema/tree/master/tests/models) to include the appropriate docstrings and description fields.

Originally posted by @jacksmith15 in #93 (comment)

@SolidTux
Copy link
Contributor Author

I did everything in a fresh virtualenv (created with pipenv for Python 3.9.2) and still get errors, mostly of the form

E1136: Value 'Union' is unsubscriptable (unsubscriptable-object)

or

AttributeError: 'Name' object has no attribute 'value'

The full log is attached.

tests.log

@jacksmith15
Copy link
Owner

jacksmith15 commented Jul 17, 2023

E1136: Value 'Union' is unsubscriptable (unsubscriptable-object)

This is an old bug with pylint on Python 3.9. I suspect the AttributeError is also a pylint bug.

pylint-dev/pylint#3882

Tests pass with Python 3.6, which is the minimum supported version of this library.

@jacksmith15
Copy link
Owner

I bumped the test dependencies in 5f87c63

I believe this issue should now be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants