Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics need to include peer name #1

Open
jacksontj opened this issue Apr 27, 2020 · 0 comments
Open

Metrics need to include peer name #1

jacksontj opened this issue Apr 27, 2020 · 0 comments

Comments

@jacksontj
Copy link
Owner

The metrics copied over in https://github.com/jacksontj/memberlistmesh/blob/master/cluster.go#L359 register with global names, which is an issue if you want to register 2 different memberlistmeshs in the same process. These should include the static label of the peer name (so we'd only have the issue if you tried to register 2 things with the same name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant