Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripgrep supports multi-line patterns -> update Readme.md #255

Closed
twmr opened this issue Feb 10, 2019 · 3 comments
Closed

Ripgrep supports multi-line patterns -> update Readme.md #255

twmr opened this issue Feb 10, 2019 · 3 comments
Assignees

Comments

@twmr
Copy link
Contributor

twmr commented Feb 10, 2019

The readme file recommends to use "ag" as the searcher if the support for multline signatures is needed.

Since rg now supports multiline pattterns this recommendation should be removed/updated.

@jacktasia
Copy link
Owner

Thanks!

@twmr
Copy link
Contributor Author

twmr commented Feb 10, 2019

Thx for this quick update. I'm not sure but I think that we also have to adapt the source code of dumb-jump, since multiline support in ripgrep is enabled with the -U cmd line flag.

@jacktasia
Copy link
Owner

I'm not sure but I think that we also have to adapt the source code of dumb-jump, since multiline support in ripgrep is enabled with the -U cmd line flag.

I think you're right. I am opening this until I get a chance to make and test this change. This should also allow us to support more rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants