-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Library doesn't work clientside #57
Comments
Oh interesting. I get "ReferenceError: Cannot access 'cross_fetch_1' before initialization". I'll see what I can do. |
My workaround (I used this answer here to create a helper app that handles cross origin: https://stackoverflow.com/questions/43871637/no-access-control-allow-origin-header-is-present-on-the-requested-resource-whe):
|
That was a fairly straightforward fix: The reason i was getting
was that I was testing the library directly in codepen with unpkg. I'm guessing you're using a bundler, so you didn't run into this. But due to the restrictive nature of CORS in the browser, i don't think there is any merit in keeping those fixes around. Whilst your CORs proxy workaround works, it may not be the right approach. This library is approximately 1MB uncompressed (and 500kb compressed with webpack). So it'd add significant bloat and then when calling unfurl it'll block the event loop. I recommend changing your CORS proxy service to do the unfurling. There is a great minimalist example here https://github.com/beeman/micro-unfurl I will make it clearer in the readme that this is a server-side library and not supported for use client-side. |
Do you not get the same CORS error with itaditya/simple-unfurl ? |
Yes I get it :/ so I added the proxy CORS thing to avoid these issues. However I think I will just add a backend endpoint today that handles this. I am just worried the library would have the same errors in the backend as well @jacktuck |
You shouldn't have the same issue as you'd have control of the endpoint - meaning you can add CORS response headers - either wildcard or specific to your domain(s). |
Thanks for the amazing work.
I noticed that the library doesn't work on any browser. It results in the error:
Your schema is amazing and i'd love to use this, however I will have to use https://github.com/itaditya/simple-unfurl for now as it works clientside as well
The text was updated successfully, but these errors were encountered: