Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search function (CTRL+K) search also css styles #720

Closed
gamberoillecito opened this issue Jan 22, 2024 · 7 comments
Closed

Search function (CTRL+K) search also css styles #720

gamberoillecito opened this issue Jan 22, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@gamberoillecito
Copy link

Describe the bug
As per title, searching anything in the website shows a lot of css results.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure you have Plugin.Latex({ renderEngine: "mathjax" }) in quartz.config.js
  2. Go here
  3. Click on search
  4. Type something such as cal
  5. At the time of writing css styles are displayed

immagine

See the screenshots below, the css seems to be related to mjx-status which seems to be part of mathjax code
The search result seems to match with this <style> element at the bottom of the page

immagine
immagine

Desktop (please complete the following information):

  • Quartz Version: v4.1.2
  • node Version: v20.5.1
  • npm version: v10.2.3
  • OS: Windows
  • Browser: Firefox
@gamberoillecito gamberoillecito added the bug Something isn't working label Jan 22, 2024
@aarnphm
Copy link
Collaborator

aarnphm commented Jan 31, 2024

hmm, I can't seem to reproduce this. Can you try updating to the latest version and the refresh the cache to see if this still persists?

@jackyzha0
Copy link
Owner

@aarnphm this is specifically using mathjax not katex, they do some weird style injection

@aarnphm
Copy link
Collaborator

aarnphm commented Jan 31, 2024

@aarnphm this is specifically using mathjax not katex, they do some weird style injection

Hmm, maybe my latex is not that complicated enough I guess. I did change to mathjax, refresh the cache, cookies and it didn't show up for me.

@jackyzha0
Copy link
Owner

jackyzha0 commented Feb 1, 2024

I believe this was fixed by a bump in our dependencies :) epic @gamberoillecito can you update to the newest version of Quartz and let us know if you still run into this?

@gamberoillecito
Copy link
Author

@jackyzha0 thank you for the help, how should I update the repo?
The problem is that the repository I'm currently working on is a fork of a fork of your repo.
Will npx quartz update work?

@jackyzha0
Copy link
Owner

Yup! Worst case you can do git pull upstream v4

@gamberoillecito
Copy link
Author

@jackyzha0 everything is working perfectly. I'm sorry it took so long. Thank you again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants