Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcluded files aren't refreshed in npx quartz build --serve #791

Closed
kabirgh opened this issue Feb 2, 2024 · 1 comment
Closed

Transcluded files aren't refreshed in npx quartz build --serve #791

kabirgh opened this issue Feb 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kabirgh
Copy link
Contributor

kabirgh commented Feb 2, 2024

Describe the bug
npx quartz build --serve does not show changes to transcluded files.

To Reproduce
Steps to reproduce the behavior:

  1. Create 1.md and 2.md.
  2. 2.md should transclude 1.md like ![[1.md]
  3. Edit 1.md.
  4. At localhost:8080/1 the changes to 2 don't show up, even after a page refresh.

Expected behavior
Changes to transcluded files should show without needing to restart the build.

Screenshots and Source
None

Desktop (please complete the following information):

  • Quartz Version: v4.1.5
  • node Version: v18.16
  • npm version: v9.6.5
  • OS: Windows 10
  • Browser: Firefox

Additional context
The renderPage function, quartz uses componentData.allFiles which seems to be empty.
Possible solutions:

  • renderPage to read the transcluded file from disk again
  • renderPage uses content from the emitter instead of allFiles. content should have the latest data
@kabirgh kabirgh added the bug Something isn't working label Feb 2, 2024
@jackyzha0
Copy link
Owner

Should be closed by your partial rebuilds PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants