fix: unhandled promise rejection when async work done after handshake #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you do async work after invoking it-handshake but before awaiting
on any of the fields of the response, an unhandledPromiseRejection can
occur if the `stream.sink` method rejects.
This manifests itself in libp2p vis `multiformats/js-multistream-select`
as:
```js
(node:82951) UnhandledPromiseRejectionWarning: Error: already piped
at Object.sink (node_modules/it-pair/index.js:10:24)
at module.exports (node_modules/it-handshake/src/index.js:15:30)
at module.exports (src/select.js:10:57)
at Dialer.select (src/index.js:27:12)
at Context.<anonymous> (test/dialer.spec.js:43:26)
```
Also:
- Updates all deps
- Removes node Buffers in favour of Uint8Arrays
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 17 21 +4
=========================================
+ Hits 17 21 +4
Continue to review full report at Codecov.
|
This was referenced Aug 12, 2020
jacobheun
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you do async work after invoking it-handshake but before awaiting
on any of the fields of the response, an unhandledPromiseRejection can
occur if the
stream.sinkmethod rejects.This manifests itself in libp2p vis
multiformats/js-multistream-selectas:
Also: