fix #96 deprecated postgres backend strings #101
Conversation
The backend "django.db.backends.postgresql_psycopg2" has been deprecated in Django 2.0 in favor of "django.db.backends.postgresql". https://docs.djangoproject.com/en/2.0/releases/2.0/#id1
| try: | ||
| from django import VERSION as DJANGO_VERSION | ||
| except ImportError: | ||
| DJANGO_VERSION = None |
There was a problem hiding this comment.
When will this be None? More to the point, when is django.VERSION not defined?
There was a problem hiding this comment.
When Django is not installed. There's no installation requirements in setup.py, and I didn't want to make the module installable but not importable.
...although adding an installation requirement for Django is probably the better way, huh?
There was a problem hiding this comment.
Based on this comment it might be hard to find a valid lower bound.
test_dj_database_url.py
Outdated
| @@ -16,7 +18,10 @@ def test_postgres_parsing(self): | |||
| url = 'postgres://uf07k1i6d8ia0v:wegauwhgeuioweg@ec2-107-21-253-135.compute-1.amazonaws.com:5431/d8r82722r2kuvn' | |||
| url = dj_database_url.parse(url) | |||
|
|
|||
| assert url['ENGINE'] == 'django.db.backends.postgresql_psycopg2' | |||
| if DJANGO_VERSION < (2, 0): | |||
There was a problem hiding this comment.
This seems to be repeated everywhere. What if we have a constant at the module level that looks like:
EXPECTED_ENGINE = 'django.db.backends.postgresql'
if DJANGO_VERSION < (2, 0):
EXPECTED_ENGINE = 'django.db.backends.postgresql_pyscopg2'And then we use EXPECTED_ENGINE in our assertions
|
This library is used by many apps that require a django older than 2.0 (or even 1.8). |
|
We should detect which version of Django they are using, and act accordingly. |
|
Ideally. |
|
Yep, it does that. Still uses the old engine for Django < 2.0. |
|
Excellent :) |
| @@ -6,4 +6,36 @@ python: | |||
| - 3.4 | |||
There was a problem hiding this comment.
@kennethreitz It seems Travis isn't running the tests any longer. Can you investigate that?
|
Closing & re-opening to trigger a travis build |
The database backend "django.db.backends.postgresql_psycopg2" has been deprecated
in Django 2.0 in favor of "django.db.backends.postgresql".
https://docs.djangoproject.com/en/2.0/releases/2.0/#id1