Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename override to overwrite. #1

Merged
merged 1 commit into from Feb 7, 2017

Conversation

flushentitypacket
Copy link
Contributor

This breaks the API, but I think it just makes way more sense to call it overwrite since that's the name of the option in Bugsnag, and actually means what it does--override sounds like changing functionality.

@flushentitypacket
Copy link
Contributor Author

Alternatively, could change the README to match override. But since no one's really using this yet, might as well nip it in the bud?

@jmshal
Copy link
Owner

jmshal commented Feb 7, 2017

Thanks @flushentitypacket, I'm still testing these plugins quite a bit, so I appreciate you finding this small gem 😛

@jmshal jmshal merged commit 26266b0 into jmshal:master Feb 7, 2017
@flushentitypacket
Copy link
Contributor Author

flushentitypacket commented Feb 7, 2017

@jacobmarshall FWIW there's another repo here doing a similar thing as well: https://github.com/bakunyo/bugsnag-sourcemap-webpack-plugin

I had to fork it to get it working for my use case, but it's pretty well done and lightweight. Could consolidate efforts!

@jmshal
Copy link
Owner

jmshal commented Feb 7, 2017

Nice, didn't know one already existed - I'm getting in touch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants