Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setRowCount(int) and setColumnCount(int) shouldn't receive -1 as undefined value #28

Open
Rafhack opened this issue Dec 15, 2015 · 2 comments

Comments

@Rafhack
Copy link

Rafhack commented Dec 15, 2015

setupVertical() and setupHorizontal() methods on QuiltViewBase class, call setColumnCount(int) and setRowCount(int) passing -1 as undefined value, this makes GridLayout throw an IllegalArgumentException. Instead, these methods should pass UNDEFINED constant as undefined value.

@bag7dad
Copy link

bag7dad commented Oct 10, 2016

solve it by remove //this.setColumnCount(-1); and //this.setColumnCount(-1); in vertical too

@arefbhrn
Copy link

arefbhrn commented May 3, 2017

@medozeus you mean setRowCount in horizontal
i think it's better to set it undefined:
this.setRowCount(UNDEFINED); // in horizontal
this.setColumnCount(UNDEFINED); // in vertical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants