-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MergeMojo implementation based on MergeTask #126
Conversation
@Godin Can you please quickly review this? This looks like a simple but valuable addition for our Maven support. |
import java.util.List; | ||
|
||
/** | ||
* Mojo for merging a set of execution data store files into a single file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation: The term is "execution data files (*.exec)" instead of "execution data store files"
I also updated the javadoc for ant task |
@hrmohr Thx! |
<fileSet> | ||
<directory>${project.parent.build.directory}</directory> | ||
<includes> | ||
<include>jacoco2.exec</include> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use single fileSet here ( *.exec ) ?
Three times yes to your questions @Godin. Should I commit these changes to the integration test? The input validation can also be improved because it wont fail if a valid fileset definition finds no execution data files for merging. It will only fail if no filesets are defined. |
@hrmohr Yes, please update the pull request directly. I wouldn't fail if no files are found, maybe just log a info. So the plugin can be used in a generic way. The list of filesets is probably more flexible. |
I kept the list of filesets and handled missing execution files as suggested. Unless you want me to change anything this should be my last changes. |
Thnak you! I'll going to merge this. |
MergeMojo implementation based on MergeTask
Same functionality as the MergeTask taking a list of FileSet as input with a single destFile output