Html formatter of report ant task only supports basic locales #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this hint! The only problem is that Locale#forLanguageTag is there since Java 7. JaCoCo is based on Java 5. Need to find another API to find the correct locale. |
|
Other libs that cannot use Java 7 (yet) usually rely on the '_' delimited format that Locale#toString produces. Unfortunately though, there's no parsing api for that. The parsing code however isn't that complicated, see e.g. https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocaleTypeDescriptor.java |
marchof
added a commit
that referenced
this pull request
Mar 30, 2015
marchof
added a commit
that referenced
this pull request
Mar 30, 2015
Html formatter of report ant task only supports basic locales
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The html elemet of the jacoco report ant task supports the 'locale' attribute. Unfortunately, there's currently no way to configure a Locale for a specific country, since ant seems to convert the String from the ant file to a Locale by invoking the constructor with one String argument, which only allows selection of language, but not of country.
To allow any Locale to be configured, you could e.g. invoke Locale#forLanguageTag.
To test this, you can use e.g. 'de' (German) and 'de-CH' (German (Switzerland)), which use different number formats, even though the language is the same.