-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
".resources" directory causes problems for github pages #401
Conversation
I think we discussed this before. We need to find a location for resources which will not collide with group or package names. |
A hyphen in the name would work. web-res ? |
You can also add |
@marchof out of curiosity - why we need to find a name, which doesn't collide with group or package names? Also what means "group" in this context? I'm asking, because indeed - hyphen allows to avoid collision with package name, but not sure about "group" name. |
@Godin because it shares the same namespace than group or package names:
If we have name clash the report is probably broken. The same would happen is there is a class named I could live with |
Be more web hosting friendly by not generating folders like ".resources".
@Godin Here is a possible solution... |
Be more web hosting friendly by not generating folders like ".resources".
@marchof LGTM 👍 and this fixes problem with our own experimental deployment to GitHub pages - before this change all images at http://jacoco.github.io/jacoco/trunk/coverage/ were broken |
👍 thanks for speedy response. |
Is there any chance to release 0.7.6.1 version which contains only this patch? |
@agabrys please wait for 0.7.7 or use snapshot version |
github/maven-plugins#112
Steps to reproduce
JaCoCo version: 0.7.6.201602180812
Operating system: Windows/gitshell
Tool integration: Maven (github-site plugin)
Expected behaviour
Reports display correctly on github site.
Actual behaviour
The .resources directory is not deployed.
I have raised an issue with the github/maven-plugins project
github/maven-plugins#112
however the problem may well not be solvable by them.
The root cause is that some software, arguably correctly, overlooked a directory starting with a dot.
Your resources directory should not be a hidden directory.
Please consider renaming it to resources.