Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

".resources" directory causes problems for github pages #401

Merged
merged 1 commit into from
May 3, 2016
Merged

Conversation

marchof
Copy link
Member

@marchof marchof commented May 2, 2016

github/maven-plugins#112

Steps to reproduce

JaCoCo version: 0.7.6.201602180812
Operating system: Windows/gitshell
Tool integration: Maven (github-site plugin)

Expected behaviour

Reports display correctly on github site.

Actual behaviour

The .resources directory is not deployed.

I have raised an issue with the github/maven-plugins project
github/maven-plugins#112
however the problem may well not be solvable by them.

The root cause is that some software, arguably correctly, overlooked a directory starting with a dot.

Your resources directory should not be a hidden directory.

Please consider renaming it to resources.

@marchof
Copy link
Member

marchof commented Apr 18, 2016

I think we discussed this before. We need to find a location for resources which will not collide with group or package names.

@Godin Godin removed their assignment Apr 18, 2016
@timp
Copy link
Author

timp commented Apr 23, 2016

A hyphen in the name would work. web-res ?

@agabrys
Copy link

agabrys commented May 1, 2016

You can also add jacoco keyword to name, e.g. jacoco-web-res.

@Godin
Copy link
Member

Godin commented May 2, 2016

@marchof out of curiosity - why we need to find a name, which doesn't collide with group or package names? Also what means "group" in this context? I'm asking, because indeed - hyphen allows to avoid collision with package name, but not sure about "group" name.

@marchof
Copy link
Member

marchof commented May 2, 2016

@Godin because it shares the same namespace than group or package names:

.resources
.sessions.html
index.html
jacoco-maven-plugin
jacoco.csv
jacoco.xml
org.jacoco.agent
org.jacoco.agent.rt
org.jacoco.ant
org.jacoco.core
org.jacoco.examples
org.jacoco.report

If we have name clash the report is probably broken. The same would happen is there is a class named index. With .sessions.html we have another dot resource which should be renamed.

I could live with jacoco-resources and jacoco-sessions.html. If somebody reports a name clash we sue him for trademark infringement ;-)

@marchof marchof self-assigned this May 2, 2016
@marchof marchof added this to the 0.7.7 milestone May 2, 2016
marchof added a commit that referenced this pull request May 2, 2016
Be more web hosting friendly by not generating folders like
".resources".
@marchof
Copy link
Member

marchof commented May 2, 2016

@Godin Here is a possible solution...

@marchof marchof closed this May 2, 2016
@marchof marchof reopened this May 2, 2016
@Godin Godin changed the title .resource directory causes problems for github pages ".resources" directory causes problems for github pages May 3, 2016
Be more web hosting friendly by not generating folders like
".resources".
@Godin
Copy link
Member

Godin commented May 3, 2016

@marchof LGTM 👍 and this fixes problem with our own experimental deployment to GitHub pages - before this change all images at http://jacoco.github.io/jacoco/trunk/coverage/ were broken

@Godin Godin deleted the issue-401 branch May 3, 2016 08:43
@timp
Copy link
Author

timp commented May 3, 2016

👍 thanks for speedy response.

@agabrys
Copy link

agabrys commented May 7, 2016

Is there any chance to release 0.7.6.1 version which contains only this patch?

@Godin
Copy link
Member

Godin commented May 7, 2016

@agabrys please wait for 0.7.7 or use snapshot version

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants