Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RoundingMode#FLOOR for percentages in HTML report #452

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Use RoundingMode#FLOOR for percentages in HTML report #452

merged 1 commit into from
Sep 26, 2016

Conversation

Godin
Copy link
Member

@Godin Godin commented Sep 24, 2016 •
edited

@Godin Godin added this to the 0.7.8 milestone Sep 24, 2016
@Godin Godin self-assigned this Sep 24, 2016
@Godin Godin mentioned this pull request Sep 24, 2016
Open
@Godin
Copy link
Member Author

Godin commented Sep 24, 2016

@marchof could you please review?

marchof
marchof approved these changes Sep 26, 2016
View reviewed changes
Copy link
Member

@marchof marchof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marchof marchof merged commit 9b1c6f5 into master Sep 26, 2016
@marchof marchof deleted the issue-452 branch September 26, 2016 18:20
@bmuschko bmuschko mentioned this pull request Dec 22, 2016
Merged
bmuschko pushed a commit to gradle/gradle that referenced this pull request Dec 24, 2016
Change coverage to avoid rounding issue jacoco/jacoco#452
1039374
@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
component: report type: enhancement
Projects
None yet
Milestone
0.7.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Godin @marchof