prepare-agent should not overwrite existing property into empty string when execution skipped #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
force-pushed
the
issue-486
branch
4 times, most recently
from
4e00daa
to
2522aa3
Compare
marchof
reviewed
Feb 1, 2017
| getLog().info(name + " set to empty"); | ||
| projectProperties.setProperty(name, ""); | ||
| } else { | ||
| getLog().info(name + " set to " + oldValue); |
There was a problem hiding this comment.
Actually we don't set anything here: Either we don't log at all or we log something like: "Keep [property] as [oldValue]".
marchof
approved these changes
Feb 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://groups.google.com/d/msg/jacoco/oWXxpvEz-dw/x1VWy3NPBgAJ