-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Artifact.SCOPE_PROVIDED artifacts to aggregate report #572
Conversation
@chonton Thanks for the contribution! May I ask you for your use case? Especially it looks like my current assumptions do not hold true:
|
My typical reactor project has three modules:
Both To prevent the This leaves provided, which seems correct, as the |
@@ -46,7 +46,20 @@ | |||
* Project source and execution data is included in the report.</li> | |||
* <li><code>test</code>: Only execution data is considered for the report.</li> | |||
* </ul> | |||
* | |||
* | |||
* A typical use case might be in a reactor project which has three modules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we need this update of Javadoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in next commit.
anything else needed to merge this PR? |
@chonton not so much - I just need to come from vacation back to work 😉 |
@chonton merged. Thank you for your contribution! 👍 |
I have an aggregate maven project where one of the projects must be scoped as 'provided'. I would like it to be still considered for inclusion in the aggregate report.