Add filter for empty constructor without parameters in enum #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
force-pushed
the
issue-640
branch
5 times, most recently
from
40e9811
to
161a8fc
Compare
|
@marchof could you please review? |
Godin
force-pushed
the
issue-640
branch
2 times, most recently
from
750e9ab
to
47a1e13
Compare
marchof
approved these changes
Feb 11, 2018
| private static class Matcher extends AbstractMatcher { | ||
| private boolean match(final MethodNode methodNode, | ||
| final String superClassName) { | ||
| firstIsLoadThis(methodNode); |
There was a problem hiding this comment.
+1 for this very readable reader declaration ;)
| * Sets {@link #cursor} to first instruction of method if it is | ||
| * <code>ALOAD 0</code>, otherwise sets it to <code>null</code>. | ||
| */ | ||
| void firstIsLoadThis(final MethodNode methodNode) { |
There was a problem hiding this comment.
Strictly speaking the method name only applies to instance methods. For static methods it would be the first argument.
There was a problem hiding this comment.
@marchof renamed into firstIsALoad0.
| @@ -17,6 +17,7 @@ | |||
| import org.objectweb.asm.Opcodes; | |||
| import org.objectweb.asm.tree.AbstractInsnNode; | |||
| import org.objectweb.asm.tree.MethodInsnNode; | |||
| import org.objectweb.asm.tree.MethodNode; | |||
| import org.objectweb.asm.tree.VarInsnNode; | |||
|
|
|||
| abstract class AbstractMatcher { | |||
There was a problem hiding this comment.
I wonder whether it would be worth to add unit tests for AbstractMatcher. Especially as we miss several branches with the rest of our test suite.
There was a problem hiding this comment.
@marchof Let's do this separately from this ticket.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #640