Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove misleading parameters of jacoco-maven-plugin goals #827

Merged
merged 2 commits into from Jan 10, 2019
Merged

Remove misleading parameters of jacoco-maven-plugin goals #827

merged 2 commits into from Jan 10, 2019

Conversation

Godin
Copy link
Member

@Godin Godin commented Jan 10, 2019

Fixes #424

@Godin Godin added this to Implementation in Current work items via automation Jan 10, 2019
@Godin Godin self-assigned this Jan 10, 2019
@Godin Godin added this to the 0.8.3 milestone Jan 10, 2019
@Godin Godin requested a review from marchof January 10, 2019 15:31
@Godin Godin moved this from Implementation to Review in Current work items Jan 10, 2019
marchof
marchof requested changes Jan 10, 2019
View reviewed changes
Copy link
Member

@marchof marchof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for picking this up! Now the documentation correctly distinguishes between class name and class file name 👍

I would like to propose some formal improvements though.

jacoco-maven-plugin/src/org/jacoco/maven/AbstractJacocoMojo.java Show resolved Hide resolved
jacoco-maven-plugin/src/org/jacoco/maven/AbstractAgentMojo.java Outdated Show resolved Hide resolved
jacoco-maven-plugin/src/org/jacoco/maven/AbstractAgentMojo.java Outdated Show resolved Hide resolved
org.jacoco.doc/docroot/doc/changes.html Outdated Show resolved Hide resolved
org.jacoco.doc/docroot/doc/changes.html Outdated Show resolved Hide resolved
@marchof marchof merged commit ee1324d into master Jan 10, 2019
Current work items automation moved this from Review to Done Jan 10, 2019
@marchof marchof deleted the issue-424 branch January 10, 2019 21:06
@jacoco jacoco locked as resolved and limited conversation to collaborators May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
component: documentation component: maven type: bug 🐛 Something isn't working
Projects
Current work items
  
Done
Milestone
0.8.3
2 participants
@Godin @marchof