Remove instrument(ClassReader)
and analyzeClass(ClassReader)
#850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several problems with methods
Instrumenter.instrument(ClassReader)
andAnalyzer.analyzeClass(ClassReader)
:addition in JaCoCo of experimental support of new bytecode version, which is not yet supported by ASM, does not apply to these methods unlike other methods in
Instrumenter
andAnalyzer
their implementations use
field
org.objectweb.asm.ClassReader.b
which was marked as deprecated in ASM 7.1they don't work in case when field
ClassReader.b
contains more than just bytes of one class (seeClassReader(byte[] classFileBuffer, int classFileOffset, int classFileLength)
) and seems that there is no easy way to fix thisSo I think that we have only two options:
@marchof WDYT?