Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concerns regarding node hitbox and item collision genericization #1312

Closed
Yomguithereal opened this issue Nov 9, 2022 · 5 comments
Closed

Comments

@Yomguithereal
Copy link
Collaborator

The idea was to add a way to specify alongside a webgl program a way to:

  1. declare the hitbox (that must be a rectangle) for a rendered node (the default being a square inscribing the node circle, basically)
  2. declare a way to check for collision (typically in viewport coordinates, against mouse position)

There are some issues there:

  1. the quadtree has no method to take an arbitrary rectangle to index (internally it can, it is more of an API problem) but we still have an issue about the sizes, wrt the framedGraph space. And the fact that this space has some blank space on the outskirts of the largest dimension (see Cleanup quadtree space #1310).
  2. regarding collisions, if we take the node case, we need the viewport positions, and the camera-scaled size. The fact is we might need arbitrary supplementary data from NodeDisplayData here to make a decision and maybe scale some other sizes (edge thickness etc.)
@stale
Copy link

stale bot commented Dec 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 19, 2022
@stale
Copy link

stale bot commented Jan 29, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 29, 2023
@sim51 sim51 added pinned and removed wontfix labels Jan 29, 2023
@jacomyal jacomyal added this to the v3.0.0 milestone Jul 24, 2023
@jacomyal
Copy link
Owner

Related to #1371

@jacomyal
Copy link
Owner

#1382 could completely solve this issue definitely.

@jacomyal
Copy link
Owner

jacomyal commented Dec 7, 2023

I close this as we have a working version of picking in the v3 branch.

@jacomyal jacomyal closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants