Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing programs with setSetting has no effect #1423

Closed
sim51 opened this issue Apr 10, 2024 · 4 comments
Closed

Changing programs with setSetting has no effect #1423

sim51 opened this issue Apr 10, 2024 · 4 comments

Comments

@sim51
Copy link
Collaborator

sim51 commented Apr 10, 2024

I'm using the node-border program in an application with light & dark mode.
So when the theme changed, I change the nodeProgramClasses by using the setSetting function.
But nothing changed in my displayed graph...

To reproduce it, check : https://codesandbox.io/p/sandbox/funny-lamport-vz4r9j

@sim51 sim51 added the bug label Apr 10, 2024
@jacomyal
Copy link
Owner

I confirm that the programs are initialized when sigma is instantiated, and that no programs settings update is handled later.

Copy link

stale bot commented Jun 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 5, 2024
@sim51 sim51 added pinned and removed wontfix labels Jun 5, 2024
@sim51
Copy link
Collaborator Author

sim51 commented Jun 5, 2024

What I purpose is to throw an error if in the function we set a program.
For now, just it doesn't work, without any notice.

@jacomyal
Copy link
Owner

jacomyal commented Jun 5, 2024

I don't like it, I'd rather forbid setting some settings that allowing it and throwing errors. I'll think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants