Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annoying error on events over elements without class names #823

Closed
Sigfried opened this issue Feb 4, 2017 · 1 comment
Closed

annoying error on events over elements without class names #823

Sigfried opened this issue Feb 4, 2017 · 1 comment
Labels

Comments

@Sigfried
Copy link

Sigfried commented Feb 4, 2017

Maybe this isn't bothering anyone else because people don't usually use the SVG renderer, but when I have DOM elements inside a node that don't have class names, sigma.misc.bindDOMEvents.js line 36 gives an error. Instead of

 return !!~this.class.indexOf(self.settings('classPrefix') + '-node');

it could be

 return this.class && !!~this.class.indexOf(self.settings('classPrefix') + '-node');

Should I just put in a pull request or is there some reason my fix is inadvisable?

@stale
Copy link

stale bot commented Oct 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 8, 2021
@stale stale bot closed this as completed Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant