Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ang in make_pol_grid is a float and doesn't have reshape method #1

Closed
RichardPflaum opened this issue Mar 16, 2020 · 5 comments
Closed

ang in make_pol_grid is a float and doesn't have reshape method #1

RichardPflaum opened this issue Mar 16, 2020 · 5 comments

Comments

@RichardPflaum
Copy link

Hi, I just cloned this and am trying to understand the module, but my Linter is complaining:
The line ang = self.angular(k, theta_i).reshape((L, 1), order='F') in the method make_pol_grid seems to be wrong, since self.angular returns a float.
@RichardPflaum
Copy link
Author

Sorry, nevermind this must be a Pylint issue.

@RichardPflaum RichardPflaum reopened this Mar 17, 2020
@RichardPflaum
Copy link
Author

RichardPflaum commented Mar 17, 2020 •
edited
Loading

The issue is caused by the angular method in the baseclass. This can be fixed using ABCMeta as metaclass for Zern and using the @abstractmethod decorator for angular instead of simply returning 0.

@jacopoantonello
Copy link
Owner

Hi. Could you please check whether a1d85c3 fixes this problem? My linter didn't show any warning, so I can't reproduce this. Thank you.

@RichardPflaum
Copy link
Author

RichardPflaum commented Mar 27, 2020 via email •
edited
Loading

@RichardPflaum
Copy link
Author

Yes that does it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacopoantonello @RichardPflaum