-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the evaluation of higher order modes #8
Comments
Perhaps it's not so hard within the code! Idea: write out a subclass of
It would then, however, need to generate So, since just fitting the overall result of adding up the modes is not an option, we need to also modify the Residuals. |
Working on this in branch hom.
|
The big problem is: do we make all this stuff still work in parallel with the old, no-modes code, or just rewrite everything? Still, it's important to not wind up with a bunch of Advantages for rewriting:
Disadvantages:
|
Or, way simpler! As thought before, just make a |
Relevant papers: PN waveforms for all modes: http://arxiv.org/abs/0710.0614 |
Tricky things:
|
There are two approaches for this:$(\ell, m)$ , or including all relevant HOMs inside the data compressed with PCA and working from there.
either training a separate
Model
for eachThe idea is to use the former approach since it's simpler; the requirements to do so are:
WaveformGenerator
->Dataset
->Model
pipeline to know which mode it's working on,The text was updated successfully, but these errors were encountered: