New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type declarations depend on dev dependencies #136
Comments
This is an unfortunate situation that I'm not really sure how to get out of.
What would you do? |
To just complete the picture for my use-case: m-ld-js uses the sparqlalgebrajs factory to construct algebra objects. So I have to pull in this module myself anyway. This means it's bundled twice, as it's already in the quadstore-comunica bundle. |
Oh boy. I was not expecting that. Apologies, then - your bundle size must have grown a little bit. The reason I moved sparqlalgebrajs inside the |
I think it may be possible for |
This would be possible, yes, but it would not lend itself well to use cases dealing with custom Comunica configurations other than You can expect a fix by the end of the day. Thank you for raising this! |
Thanks! No problem & no huge rush. The good news is that with a temporary import of these deps, m-ld-js+quadstore@9 is passing all unit & compliance tests! |
Hello again @gsvarovsky ! Could you please try again with |
It works! |
Fixed in |
When importing quadstore@9 into a dependent project using Typescript:
These modules are dev dependencies.
As types have no runtime cost I think it might be fine to make
@comunica/types
a core dependency. However forsparqlalgebra
a bundler might pull that project into the runtime. Perhaps type-only imports & exports can help here?The text was updated successfully, but these errors were encountered: